Skip to content

Fixes some testing issues#59

Merged
Calvin-Xu merged 9 commits intomainfrom
final-swiftlint-periphery-fixes
Mar 14, 2025
Merged

Fixes some testing issues#59
Calvin-Xu merged 9 commits intomainfrom
final-swiftlint-periphery-fixes

Conversation

@shamit05
Copy link
Copy Markdown
Contributor

Fixes some testing issues

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Calvin-Xu Calvin-Xu self-requested a review March 14, 2025 19:06
Copy link
Copy Markdown
Contributor

@Calvin-Xu Calvin-Xu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's try to get tests less flaky to the extent we can.

@Calvin-Xu Calvin-Xu enabled auto-merge (squash) March 14, 2025 19:38
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.69%. Comparing base (a0477fa) to head (2a5de62).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   76.07%   75.69%   -0.38%     
==========================================
  Files          39       39              
  Lines        3556     3529      -27     
==========================================
- Hits         2705     2671      -34     
- Misses        851      858       +7     
Files with missing lines Coverage Δ
Feedbridge/Views/Dashboard/DehydrationCharts.swift 97.35% <100.00%> (+0.03%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d735fda...2a5de62. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Calvin-Xu Calvin-Xu merged commit ff717e1 into main Mar 14, 2025
11 of 12 checks passed
@Calvin-Xu Calvin-Xu deleted the final-swiftlint-periphery-fixes branch March 14, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants